fix(tower): create_sub_issue duplicate check fallback by name pattern by volodchenkov · Pull Request #20 · volodchenkov/plane-conductor

volodchenkov · 2026-05-12T19:20:15Z

Summary

Add a second-layer duplicate check in create_sub_issue by canonical title pattern (<Role>: <root_name> (<identifier>)), complementing the existing label-based check.
The label-only check missed the COINEX-48 / COINEX-50 incident on 2026-05-09: two SPEC sub-issues created under the same root after the original COINEX-38, with labels: [] (cause not pinned down; the labels were either dropped after create or stripped by a later workflow).
Title is deterministic from role + root_name, so it survives any label-loss incident.
Reorder pre-condition: GET root before list_issues so the title is known at filter time.
Existing label-check test updated to mock the extra GET; new test covers the empty-labels-but-matching-name case.
Bumps to 0.3.5 (patch — behavioural fix, no API surface change).

Test plan

pytest tests/test_mcp_tower.py -k create_sub_issue — 6/6 green
pytest tests/ — full suite green (no regressions)
Manual: trigger sark on a root that already has a SPEC sub-issue with empty labels → expect DuplicateSubIssueError instead of a second sub-issue.

🤖 Generated with Claude Code

Summary by CodeRabbit

Bug Fixes
- Improved duplicate sub-issue detection to also treat cases where an existing child’s name matches the expected title even if label markers are missing.
Tests
- Added a regression test for name-based duplicate detection and updated an existing duplicate-detection test.
Chores
- Bumped package version to 0.3.5.
Documentation
- Added/expanded docstrings for several helper and wrapper utilities.

coderabbitai · 2026-05-12T19:20:27Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e8e92596-119c-4699-9119-5adf9ec79199

📥 Commits

Reviewing files that changed from the base of the PR and between a5d9fc5 and b66252f.

📒 Files selected for processing (1)

src/plane_conductor/mcp_tower.py

🚧 Files skipped from review as they are similar to previous changes (1)

src/plane_conductor/mcp_tower.py

Walkthrough

Version 0.3.5 improves duplicate detection in sub-issue creation by adding name-based matching as a fallback. The create_sub_issue function now fetches the root issue, builds the expected title, and treats a child as a duplicate if its labels contain the artifact UUID or its name matches the expected title.

Changes

Duplicate Detection Enhancement & Release Update

Layer / File(s)	Summary
Version release update `pyproject.toml`	Package version bumped from 0.3.4 to 0.3.5.
create_sub_issue duplicate-detection (core + tests) `src/plane_conductor/mcp_tower.py`, `tests/test_mcp_tower.py`	`create_sub_issue` now loads the root issue to compute the canonical sub-issue title and detects duplicates when a child under the root either has the role's artifact-label UUID in `labels` or its `name` matches the expected title. `DuplicateSubIssueError` wording updated. Existing duplicate test now mocks root fetch; new test added asserting name-based duplicate detection when labels are empty.
Docstrings and helper clarifications `src/plane_conductor/mcp_tower.py`	Added or clarified docstrings for WorkspaceContext label helpers, TowerRegistry slugs, client/emit shims, lock creation, comment helpers, HTML stripping, role display mapping, and entrypoint boot logic.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

volodchenkov/plane-conductor#7: Both PRs modify the same create_sub_issue duplicate-detection/serialization logic and tests in src/plane_conductor/mcp_tower.py.
volodchenkov/plane-conductor#17: Related — both PRs change create_sub_issue behavior in src/plane_conductor/mcp_tower.py (duplicate-detection/post-create handling).

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: a duplicate detection fallback in create_sub_issue that checks by name pattern when label-based checks miss duplicates.
Docstring Coverage	✅ Passed	Docstring coverage is 96.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/create-sub-issue-name-fallback-check

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/plane_conductor/mcp_tower.py`:
- Around line 699-734: The file fails ruff format --check; run the formatter and
commit the formatted file (e.g., run `ruff format
src/plane_conductor/mcp_tower.py`) so the block around root, root_name, seq,
identifier, title, items, existing and the DuplicateSubIssueError raise is
properly formatted; ensure wrapping, indentation, and trailing commas match
ruff's rules and then re-run the linter before pushing.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f4603007-f309-4bb3-ab9b-083f317fea77

📥 Commits

Reviewing files that changed from the base of the PR and between 1214d98 and 90d9188.

📒 Files selected for processing (3)

pyproject.toml
src/plane_conductor/mcp_tower.py
tests/test_mcp_tower.py

The label-only duplicate check in create_sub_issue lets through duplicate sub-issues if the existing one has `labels: []` (e.g. dropped after create by some downstream workflow). This happened in production around 2026-05-09: two SPEC sub-issues (COINEX-48 / COINEX-50) were created under the same root after the original COINEX-38 — both had `labels: []` so the label match in the pre-condition missed them. Add a second-layer check on the canonical title pattern `<Role>: <root_name> (<identifier>)`. The title is deterministic from the role + root, so it survives any label-loss incident and acts as a defence-in-depth complement to the label check. Reorder the pre-condition: GET root before list_issues so the title is known when we filter. Existing label-check test updated to mock the extra GET; new test covers the empty-labels-but-matching-name case. Bumps to 0.3.5 (patch — behavioural fix, no API surface change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai

🧹 Nitpick comments (1)

src/plane_conductor/mcp_tower.py (1)

706-723: ⚡ Quick win

Name-fallback duplicate check can miss matches after root rename

On Line 722, the fallback uses full-title equality (name == title). If labels are lost and the root issue name later changes, this check won’t match the old sub-issue title, so duplicates can still be created. Prefer matching stable parts (role prefix + (<identifier>) suffix) instead of full root_name.

Proposed tweak

-        title = f"{_role_display(role)}: {root_name} ({identifier})"
+        role_prefix = f"{_role_display(role)}:"
+        expected_suffix = f" ({identifier})"
+        title = f"{role_prefix} {root_name}{expected_suffix}"
@@
-            if str(i.get("parent") or "") == root_uuid
-            and (label_uuid in (i.get("labels") or []) or str(i.get("name") or "").strip() == title)
+            if str(i.get("parent") or "") == root_uuid
+            and (
+                label_uuid in (i.get("labels") or [])
+                or (
+                    str(i.get("name") or "").strip().startswith(f"{role_prefix} ")
+                    and str(i.get("name") or "").strip().endswith(expected_suffix)
+                )
+            )

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/plane_conductor/mcp_tower.py` around lines 706 - 723, The current
duplicate check builds title and then matches full name equality, which fails if
the root_name part later changes; update the existing list comprehension (the
existing variable computation that filters plane.list_issues results) to detect
fallback matches by checking for the stable pieces instead of full title
equality — e.g., require the issue name to include the role prefix from
_role_display(role) and to end with the identifier suffix "(<identifier>)" (or
otherwise match a regex like ^<role_prefix>.*\(<identifier>\)$) while keeping
the original label_uuid membership check; adjust references to title, root_name,
identifier, and label_uuid in that comprehension accordingly.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/plane_conductor/mcp_tower.py`:
- Around line 706-723: The current duplicate check builds title and then matches
full name equality, which fails if the root_name part later changes; update the
existing list comprehension (the existing variable computation that filters
plane.list_issues results) to detect fallback matches by checking for the stable
pieces instead of full title equality — e.g., require the issue name to include
the role prefix from _role_display(role) and to end with the identifier suffix
"(<identifier>)" (or otherwise match a regex like
^<role_prefix>.*\(<identifier>\)$) while keeping the original label_uuid
membership check; adjust references to title, root_name, identifier, and
label_uuid in that comprehension accordingly.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c90e3ec-5f59-4ac8-9e56-115589bc06c4

📥 Commits

Reviewing files that changed from the base of the PR and between 90d9188 and a5d9fc5.

📒 Files selected for processing (3)

pyproject.toml
src/plane_conductor/mcp_tower.py
tests/test_mcp_tower.py

✅ Files skipped from review due to trivial changes (1)

pyproject.toml

🚧 Files skipped from review as they are similar to previous changes (1)

tests/test_mcp_tower.py

CodeRabbit pre-merge check flagged docstring coverage at 75% (threshold 80%). Cover every helper in the file: registry helpers (label_uuid / artifact_label_uuid / slugs), mention rendering (_initiator_mention), HTTP client factory (_client_for), result projection (_summarize_issue), title helpers (_role_display / _strip_inline_tags), the asyncio.Lock factory for create_sub_issue, the JSON-line call-log emitter and its `mcp.tool` wrapper, the two nested `_comment_text` helpers in read_artifact / list_comments, and the entry-point helpers (_conductor_dir, _async_main). Each docstring captures the WHY rather than restating the signature. interrogate: 100.0% on src/plane_conductor/mcp_tower.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

coderabbitai Bot reviewed May 12, 2026

View reviewed changes

Comment thread src/plane_conductor/mcp_tower.py

volodchenkov force-pushed the fix/create-sub-issue-name-fallback-check branch from 90d9188 to a5d9fc5 Compare May 12, 2026 19:36

coderabbitai Bot reviewed May 12, 2026

View reviewed changes

volodchenkov merged commit bb1f689 into main May 12, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(tower): create_sub_issue duplicate check fallback by name pattern#20

fix(tower): create_sub_issue duplicate check fallback by name pattern#20
volodchenkov merged 2 commits into
mainfrom
fix/create-sub-issue-name-fallback-check

volodchenkov commented May 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

volodchenkov commented May 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

volodchenkov commented May 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 12, 2026 •

edited

Loading